It's very embarrassing to admit, but the code that was handling guild profile expirations was
SHIT. It needed a complete rewrite bad, but I always put that work off.
Then last week when the
action logs for guild profiles feature went live and I starting browsing profiles to see if everything is okay, and I noticed it again how visible the screwup is. Yes, even the logging tool showed the issues:
- double emails being sent out to everyone when there was more than 1 guild being managed by the script at the time
- warning and disabling at the same hour even though there should be a day between the two (warning couldnt be sent for whatever reason earlier)
- if the email couldnt be sent out, no other action would be taken - even though sending a PM and actually managing the guild has nothing to do with the email
- typos in the text included in the email and the PM
Yes, the situation was that crappy.
But now thankfully that is going to be behind us, as tonight I've completelly rewritten the code from the ground up. Since the issues were very severe with the older one, this new script is already in action for 25% of the guilds as I monitor and fix the remaining issues.
Sorry guys
